From 60542ac9fd078d5f87fa5f91131432d8a316bb0f Mon Sep 17 00:00:00 2001 From: Bram Moolenaar <Bram@vim.org> Date: Sun, 12 Feb 2012 20:14:01 +0100 Subject: [PATCH] updated for version 7.3.442 Problem: Still read modelines for ":doautocmd". Solution: Move check for <nomodeline> to separate function. --- runtime/doc/autocmd.txt | 14 ++++++++------ src/ex_docmd.c | 10 +++++++--- src/fileio.c | 25 ++++++++++++++++++------- src/proto/fileio.pro | 1 + src/version.c | 2 ++ 5 files changed, 36 insertions(+), 16 deletions(-) diff --git a/runtime/doc/autocmd.txt b/runtime/doc/autocmd.txt index 1e2bc77376..8e1e94ba23 100644 --- a/runtime/doc/autocmd.txt +++ b/runtime/doc/autocmd.txt @@ -1072,6 +1072,14 @@ option will not cause any commands to be executed. argument is included, Vim executes only the matching autocommands for that group. Note: if you use an undefined group name, Vim gives you an error message. + *<nomodeline>* + After applying the autocommands the modelines are + processed, so that their settings overrule the + settings from autocommands, like what happens when + editing a file. This is skipped when the <nomodeline> + argument is present. You probably want to use + <nomodeline> for events that are not used when loading + a buffer, such as |User|. *:doautoa* *:doautoall* :doautoa[ll] [<nomodeline>] [group] {event} [fname] @@ -1085,12 +1093,6 @@ option will not cause any commands to be executed. This command is intended for autocommands that set options, change highlighting, and things like that. - After applying the autocommands the modelines are - processed, so that their settings overrule the - settings from autocommands, like what happens when - editing a file. This is skipped when the <nomodeline> - argument is present. - ============================================================================== 10. Using autocommands *autocmd-use* diff --git a/src/ex_docmd.c b/src/ex_docmd.c index 83bf50c4b1..133fa7d688 100644 --- a/src/ex_docmd.c +++ b/src/ex_docmd.c @@ -4955,7 +4955,7 @@ ex_abclear(eap) map_clear(eap->cmd, eap->arg, TRUE, TRUE); } -#ifdef FEAT_AUTOCMD +#if defined(FEAT_AUTOCMD) || defined(PROTO) static void ex_autocmd(eap) exarg_T *eap; @@ -4982,8 +4982,12 @@ ex_autocmd(eap) ex_doautocmd(eap) exarg_T *eap; { - (void)do_doautocmd(eap->arg, TRUE); - do_modelines(0); + char_u *arg = eap->arg; + int call_do_modelines = check_nomodeline(&arg); + + (void)do_doautocmd(arg, TRUE); + if (call_do_modelines) /* Only when there is no <nomodeline>. */ + do_modelines(0); } #endif diff --git a/src/fileio.c b/src/fileio.c index 6d1bbbc174..a06452fdb5 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -8740,13 +8740,7 @@ ex_doautoall(eap) aco_save_T aco; buf_T *buf; char_u *arg = eap->arg; - int call_do_modelines = TRUE; - - if (STRNCMP(arg, "<nomodeline>", 12) == 0) - { - call_do_modelines = FALSE; - arg = skipwhite(arg + 12); - } + int call_do_modelines = check_nomodeline(&arg); /* * This is a bit tricky: For some commands curwin->w_buffer needs to be @@ -8785,6 +8779,23 @@ ex_doautoall(eap) check_cursor(); /* just in case lines got deleted */ } +/* + * Check *argp for <nomodeline>. When it is present return FALSE, otherwise + * return TRUE and advance *argp to after it. + * Thus return TRUE when do_modelines() should be called. + */ + int +check_nomodeline(argp) + char_u **argp; +{ + if (STRNCMP(*argp, "<nomodeline>", 12) == 0) + { + *argp = skipwhite(*argp + 12); + return FALSE; + } + return TRUE; +} + /* * Prepare for executing autocommands for (hidden) buffer "buf". * Search for a visible window containing the current buffer. If there isn't diff --git a/src/proto/fileio.pro b/src/proto/fileio.pro index cb4012f8eb..d65ec7cfe7 100644 --- a/src/proto/fileio.pro +++ b/src/proto/fileio.pro @@ -35,6 +35,7 @@ void au_event_restore __ARGS((char_u *old_ei)); void do_autocmd __ARGS((char_u *arg, int forceit)); int do_doautocmd __ARGS((char_u *arg, int do_msg)); void ex_doautoall __ARGS((exarg_T *eap)); +int check_nomodeline __ARGS((char_u **argp)); void aucmd_prepbuf __ARGS((aco_save_T *aco, buf_T *buf)); void aucmd_restbuf __ARGS((aco_save_T *aco)); int apply_autocmds __ARGS((event_T event, char_u *fname, char_u *fname_io, int force, buf_T *buf)); diff --git a/src/version.c b/src/version.c index 9285e438ae..35aa34c855 100644 --- a/src/version.c +++ b/src/version.c @@ -714,6 +714,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 442, /**/ 441, /**/ -- GitLab